Differential D17770

[electrum] Add native eCash support for compatible Trezor One firmware
ClosedPublic
Actions

Authored by Fabien on Mon, Mar 10, 13:26.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc9a42a9daf58: [electrum] Add native eCash support for compatible Trezor One firmware

Summary

The 1.13.0 firmware for the Trezor One introduced support for eCash derivation path, address and amounts. Let's use it if possible.

Test Plan

With an up-to-date Trezor 1, open an existing wallet and check it still works in the BCH compatibility mode.
Create a new wallet, check it defaults to derivation 899. Send a tx and check the device screen properly shows XEC amounts and eCash addresses.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

electrum_trezor_one_ecash

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32636
Build 64760: Build Diff	electrum-tests
Build 64759: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, Mar 10, 13:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Mar 10, 13:26

Fabien requested review of this revision.Mon, Mar 10, 13:26

Harbormaster completed remote builds in B32636: Diff 52989.Mon, Mar 10, 13:28

PiRK accepted this revision.Mon, Mar 10, 13:29

This revision is now accepted and ready to land.Mon, Mar 10, 13:29

Fabien retitled this revision from [electrum] Has native eCash support for compatible Trezor One firmware to [electrum] Add native eCash support for compatible Trezor One firmware.Mon, Mar 10, 14:44

Closed by commit rABCc9a42a9daf58: [electrum] Add native eCash support for compatible Trezor One firmware (authored by Fabien). · Explain WhyMon, Mar 10, 14:45

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc9a42a9daf58: [electrum] Add native eCash support for compatible Trezor One firmware.