Page MenuHomePhabricator

[ecash-lib-wasm] Add readme with installation instructions
Needs ReviewPublic

Authored by emack on Tue, Mar 11, 04:53.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Summary

I've fielded a few questions now on how to resolve the wasm related dependency errors when trying to run Cashtab after some of the dependency modules have been updated.

This is the only repo without a readme - add one.

Test Plan

Plonk into https://jbt.github.io/markdown-editor/ and proof read

Event Timeline

emack requested review of this revision.Tue, Mar 11, 04:53
bytesofman added inline comments.
modules/ecash-lib-wasm/README.md
7 ↗(On Diff #53006)

better to just link to a site with this and avoid specific scripted instructions for docker installation in this README.

these install instructions are likely to change / vary for different systems

we do not want to maintain docker installation steps in the ecash-lib-wasm repo

This revision now requires changes to proceed.Tue, Mar 11, 13:14
emack marked an inline comment as done.

Linked docker installation guide

Fabien added inline comments.
modules/ecash-lib-wasm/README.md
5 ↗(On Diff #53066)

It doesn't install ecash-lib-wasm

14 ↗(On Diff #53066)

What about the build without docker ?

Fabien requested changes to this revision.Thu, Mar 13, 08:38
This revision now requires changes to proceed.Thu, Mar 13, 08:38