Differential D17792

Reset the block template in the constructor
ClosedPublic
Actions

Authored by Fabien on Mar 12 2025, 20:38.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC65cd0d3d2796: Reset the block template in the constructor

Summary

This initalize the block template with the reserved coinbase size when constructed. There is no change in behavior because resetBlock() is already called in the callsites, but it makes the code easier to reason about.

Depends on D17791.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 12 2025, 20:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 12 2025, 20:38

Fabien requested review of this revision.Mar 12 2025, 20:38

Harbormaster completed remote builds in B32695: Diff 53060.Mar 12 2025, 20:47

PiRK accepted this revision.Mar 13 2025, 07:55

This revision is now accepted and ready to land.Mar 13 2025, 07:55

Closed by commit rABC65cd0d3d2796: Reset the block template in the constructor (authored by Fabien). · Explain WhyMar 13 2025, 14:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC65cd0d3d2796: Reset the block template in the constructor.

Revision Contents
Changeset List

Path

Size

src/

node/

miner.cpp

2 lines

Diff 53080

View Options

Reset the block template in the constructorClosedPublicActions