[electrum] Make the coin consolidator not burn alp tokens
ClosedPublic
Actions

Authored by PiRK on Fri, Mar 14, 12:39.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCf9a8f5d46c53: [electrum] Make the coin consolidator not burn alp tokens

Summary

Change the "Include SLP tokens" option to a more generic "Inlude tokens" that covers both SLP and ALP.
Don't burn ALP tokens unless this option is checked.
Update the warning message.

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Fri, Mar 14, 12:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Mar 14, 12:39

PiRK requested review of this revision.Fri, Mar 14, 12:39

Harbormaster completed remote builds in B32725: Diff 53108.Fri, Mar 14, 12:41

PiRK added a child revision: D17808: [electrum] properly exclude ALP tokens when sending XEC.Fri, Mar 14, 14:21

TIL coin consolidator is a thing in electrum

how is this used in the GUI? is this just called in normal tx building?

In D17806#405784, @bytesofman wrote:

TIL coin consolidator is a thing in electrum

how is this used in the GUI? is this just called in normal tx building?

You find it in the context menu in the coins tab and in the address tab. It is a way to reduce the number of utxos in a single address, as a way to work around the issue of the automatic coin selection algorithm making transactions that are too large because is insists on spending all coins for a given address at the same time.