Differential D17829

[avalanche] Add to the recently finalized items filter at callsite
ClosedPublic
Actions

Authored by Fabien on Wed, Mar 19, 19:54.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABCd0d90118ccea: [avalanche] Add to the recently finalized items filter at callsite

Summary

With pre-consensus, we want to mark final all the txs that are parents of the one being finalized. This implies that there is more logic before adding an item to the recently finalized filter, and to achieve that we move the responsability of filling the filter to the callsite.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Wed, Mar 19, 19:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 19, 19:54

Fabien requested review of this revision.Wed, Mar 19, 19:54

Harbormaster completed remote builds in B32772: Diff 53185.Wed, Mar 19, 20:08

Fabien added a child revision: D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.Wed, Mar 19, 20:48

This looks a bit odd to move it to the callsite but since it is moving in the right direction with regards to the processor FIXME, it is probably a small step in the right direction.

This revision is now accepted and ready to land.Wed, Mar 19, 22:53

Closed by commit rABCd0d90118ccea: [avalanche] Add to the recently finalized items filter at callsite (authored by Fabien). · Explain WhyWed, Mar 19, 23:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd0d90118ccea: [avalanche] Add to the recently finalized items filter at callsite.