Page MenuHomePhabricator

Refactor duplicate input check
ClosedPublic

Authored by deadalnix on Sep 17 2018, 21:58.

Details

Summary
  • Use std::unordered_set instead of std::set.
  • Do not try to check duplicate input for coinbase.
  • Always check duplicate input for regular transactions.
Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 17 2018, 21:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2018, 21:58
schancel accepted this revision.Sep 17 2018, 22:04
This revision is now accepted and ready to land.Sep 17 2018, 22:04
deadalnix updated this revision to Diff 4954.Sep 17 2018, 22:20

Just always check

deadalnix edited the summary of this revision. (Show Details)Sep 17 2018, 22:21
This revision was automatically updated to reflect the committed changes.