Page MenuHomePhabricator
Differential D17926

validation: Don't assume m_chain_tx_count in GuessVerificationProgress
ClosedPublic
Actions

Authored by PiRK on Sat, Apr 12, 07:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe3c0e83285c4: validation: Don't assume m_chain_tx_count in GuessVerificationProgress
Summary

In the context of an a descriptor import during assumeutxo background sync, the progress can not be estimated due to m_chain_tx_count being set to 0.

This is a partial backport of core#30909
https://github.com/bitcoin/bitcoin/pull/30909/commits/27f99b6d63b7ca2d4fcb9db3e88ed66c024c59d5

Depends on D17925

Test Plan

tested via the wallet_assumeutxo.py test on my dev branch ("Test loading descriptors during background sync")

This only affects logging in production builds, no change in behavior

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sat, Apr 12, 07:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Apr 12, 07:57
PiRK requested review of this revision.Sat, Apr 12, 07:57
teamcity edited the summary of this revision. (Show Details)Sat, Apr 12, 07:57
PiRK added inline comments.Sat, Apr 12, 07:59
src/validation.cpp
6368 ↗(On Diff #53461)

we will eventually get to the nChainTx -> m_chain_tx_count renaming, so better to use the new name in this log so we don't forget to update it later

PiRK added a child revision: D17927: rpc: Improve importdescriptor RPC error messages.Sat, Apr 12, 08:01
Harbormaster completed remote builds in B32951: Diff 53461.Sat, Apr 12, 08:10
Fabien accepted this revision.Mon, Apr 14, 08:51
This revision is now accepted and ready to land.Mon, Apr 14, 08:51
Closed by commit rABCe3c0e83285c4: validation: Don't assume m_chain_tx_count in GuessVerificationProgress (authored by Fabian Jahr <fjahr@protonmail.com>, committed by PiRK). · Explain WhyMon, Apr 14, 10:58
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe3c0e83285c4: validation: Don't assume m_chain_tx_count in GuessVerificationProgress.

Revision Contents
Changeset List

PathSize
src/
11 lines

Diff 53471

View Options

src/validation.cpp

Loading...