Paths

Table of Contentst

Differential D17943

rpc: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG
ClosedPublic
Actions

Authored by PiRK on Thu, Apr 17, 08:06.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC92b26b9a5582: rpc: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG

Summary

Remove deprecated RPCArg::Optional::OMITTED_NAMED_ARG in favour of OMITTED.
See D16315 for the deprecation.

-BEGIN VERIFY SCRIPT-
sed -i -e "/Deprecated alias for OMITTED, can be removed/d" src/rpc/util.h src/rpc/util.cpp
sed -i -e "s/OMITTED_NAMED_ARG/OMITTED/g" $(git grep -l "OMITTED_NAMED_ARG" src/)
-END VERIFY SCRIPT-

Also improve doc for RPCArg::Optional::OMITTED.

This is a backport of core#26919
Depends on D17942

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32993
Build 65470: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 65469: arc lint + arc unit

Event Timeline

PiRK created this revision.Thu, Apr 17, 08:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Apr 17, 08:06

PiRK requested review of this revision.Thu, Apr 17, 08:06

teamcity edited the summary of this revision. (Show Details)Thu, Apr 17, 08:06

PiRK added a child revision: D17944: rpc: Add MaybeArg() and Arg() default helper.Thu, Apr 17, 08:09

Harbormaster completed remote builds in B32993: Diff 53519.Thu, Apr 17, 08:22

Fabien accepted this revision.Thu, Apr 17, 10:49

This revision is now accepted and ready to land.Thu, Apr 17, 10:49

Closed by commit rABC92b26b9a5582: rpc: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG (authored by PiRK). · Explain WhyThu, Apr 17, 11:07

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC92b26b9a5582: rpc: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG.

Revision Contents
Changeset List

Path

Size

src/

rpc/

6 lines

29 lines

rawtransaction.cpp

7 lines

2 lines

3 lines

14 lines

2 lines

wallet/

rpc/

5 lines

51 lines

Diff 53519

src/rpc/mining.cpp

Loading...

src/rpc/misc.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/rpc/server.cpp

Loading...

src/rpc/txoutproof.cpp

Loading...

src/rpc/util.h

Loading...

src/rpc/util.cpp

Loading...

src/wallet/rpc/backup.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...