Differential D17953

rpc: Add specific error code for "wallet already loaded"
ClosedPublic
Actions

Authored by Fabien on Sat, Apr 19, 12:34.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC27e36bd3a7f4: rpc: Add specific error code for "wallet already loaded"

Summary

Add a separate RPC error code for "wallet already loaded" to avoid having to match on message to detect this.

Backport of core#20964.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sat, Apr 19, 12:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Apr 19, 12:34

Fabien requested review of this revision.Sat, Apr 19, 12:34

teamcity edited the summary of this revision. (Show Details)Sat, Apr 19, 12:34

Harbormaster completed remote builds in B33017: Diff 53558.Sat, Apr 19, 12:51

Fabien added a child revision: D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.Sat, Apr 19, 14:28

PiRK accepted this revision.Sat, Apr 19, 16:45

This revision is now accepted and ready to land.Sat, Apr 19, 16:45

Closed by commit rABC27e36bd3a7f4: rpc: Add specific error code for "wallet already loaded" (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by Fabien). · Explain WhySun, Apr 20, 19:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC27e36bd3a7f4: rpc: Add specific error code for "wallet already loaded".

Revision Contents
Changeset List

Path

Size

src/

rpc/

protocol.h

2 lines

wallet/

rpc/

util.cpp

17 lines

test/

functional/

wallet_multiwallet.py

4 lines

Diff 53568

View Options

src/rpc/protocol.h

View Options

src/wallet/rpc/util.cpp

View Options

test/functional/wallet_multiwallet.py

rpc: Add specific error code for "wallet already loaded"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53568

src/rpc/protocol.h

src/wallet/rpc/util.cpp

test/functional/wallet_multiwallet.py

rpc: Add specific error code for "wallet already loaded"
ClosedPublic
Actions

Revision Contents
Changeset List