Differential D17957

wallet: refactor GetNewDestination, use BResult
ClosedPublic
Actions

Authored by Fabien on Mon, Apr 21, 10:42.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf1a8ad562a9c: wallet: refactor GetNewDestination, use BResult

Summary

Completes backport of core#25218: https://github.com/bitcoin/bitcoin/pull/25218/commits/111ea3ab711414236f8678566a7884d48619b2d8

Partial backport of core#25721.

Depends on D17956.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR25218_2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33027
Build 65538: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang · build-clang-tidy · build-diff · build-debug
Build 65537: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, Apr 21, 10:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 21, 10:42

Fabien requested review of this revision.Mon, Apr 21, 10:42

teamcity edited the summary of this revision. (Show Details)Mon, Apr 21, 10:42

Harbormaster completed remote builds in B33027: Diff 53572.Mon, Apr 21, 10:55

PiRK accepted this revision.Mon, Apr 21, 11:33

This revision is now accepted and ready to land.Mon, Apr 21, 11:33

Closed by commit rABCf1a8ad562a9c: wallet: refactor GetNewDestination, use BResult (authored by furszy <matiasfurszyfer@protonmail.com>, committed by Fabien). · Explain WhyMon, Apr 21, 11:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf1a8ad562a9c: wallet: refactor GetNewDestination, use BResult.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

wallet.h

5 lines

qt/

addresstablemodel.cpp

13 lines

paymentserver.cpp

8 lines

test/

util/

wallet.cpp

10 lines

wallet/

8 lines

22 lines

15 lines

41 lines

test/

coinselector_tests.cpp

7 lines

wallet_tests.cpp

5 lines

wallet.h

8 lines

wallet.cpp

39 lines

Diff 53572

View Options

src/interfaces/wallet.h

View Options

src/qt/addresstablemodel.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/test/util/wallet.cpp

View Options

src/wallet/interfaces.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

src/wallet/test/coinselector_tests.cpp

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/wallet.h

View Options

wallet: refactor GetNewDestination, use BResultClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53572

src/interfaces/wallet.h

src/qt/addresstablemodel.cpp

src/qt/paymentserver.cpp

src/test/util/wallet.cpp

src/wallet/interfaces.cpp

src/wallet/rpcwallet.cpp

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/test/coinselector_tests.cpp

src/wallet/test/wallet_tests.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

wallet: refactor GetNewDestination, use BResult
ClosedPublic
Actions

Revision Contents
Changeset List