Differential D17960

gui: Unregister wallet notifications before unloading wallets
ClosedPublic
Actions

Authored by Fabien on Mon, Apr 21, 15:27.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC28cb76e32139: gui: Unregister wallet notifications before unloading wallets

Summary

This change was originally part of both bitcoin/bitcoin#10102 and
bitcoin/bitcoin#19101 and is required for both because it avoids the IPC
wallet implementation in bitcoin/bitcoin#10102 and the WalletContext
implementation in bitcoin/bitcoin#19101 needing to deal with
notification objects that have stale pointers to deleted wallets.

Backport of core-gui#360.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, Apr 21, 15:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 21, 15:27

Fabien requested review of this revision.Mon, Apr 21, 15:27

teamcity edited the summary of this revision. (Show Details)Mon, Apr 21, 15:27

Harbormaster completed remote builds in B33032: Diff 53579.Mon, Apr 21, 15:45

PiRK accepted this revision.Mon, Apr 21, 15:58

This revision is now accepted and ready to land.Mon, Apr 21, 15:58

Closed by commit rABC28cb76e32139: gui: Unregister wallet notifications before unloading wallets (authored by Fabien). · Explain WhyMon, Apr 21, 18:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC28cb76e32139: gui: Unregister wallet notifications before unloading wallets.

PiRK mentioned this in D17952: refactor: remove ::vpwallets and related global variables.Mon, Apr 21, 18:36

Revision Contents
Changeset List

Path

Size

src/

qt/

11 lines

Diff 53581

src/qt/bitcoin.cpp

Loading...