Page MenuHomePhabricator
Differential D17977

Work around a bug in clang < 13
ClosedPublic
Actions

Authored by Fabien on Wed, Apr 23, 09:19.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC3a7b1c4ac7ec: Work around a bug in clang < 13
Summary

Our OSX CI currently uses clang 12 which is failing due to a bug. Fortunately it's easy to work around this bug and we already have an occurrence of this in our codebase.

The best solution would be to move to clang >= 13 as we aim to use C++20 in the future anyway, but for now this fixes the immediate issue.

Test Plan
ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Wed, Apr 23, 09:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 23, 09:19
Fabien requested review of this revision.Wed, Apr 23, 09:19
PiRK accepted this revision.Wed, Apr 23, 09:21
This revision is now accepted and ready to land.Wed, Apr 23, 09:21
This revision was landed with ongoing or failed builds.Wed, Apr 23, 09:22
Closed by commit rABC3a7b1c4ac7ec: Work around a bug in clang < 13 (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC3a7b1c4ac7ec: Work around a bug in clang < 13.
Harbormaster completed remote builds in B33061: Diff 53626.Wed, Apr 23, 09:45

Revision Contents
Changeset List

PathSize
src/
wallet/
15 lines

Diff 53627

View Options

src/wallet/interfaces.cpp

Loading...