Page MenuHomePhabricator
Differential D17982

wallet: Reset chain notifications handler if AttachChain fails
ClosedPublic
Actions

Authored by Fabien on Wed, Apr 23, 15:25.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC5eb5cf6515fe: wallet: Reset chain notifications handler if AttachChain fails
Summary
AttachChain will create the chain notifications handler which contains a
reference to the wallet's shared_ptr. If AttachChain fails, the wallet
needs to be unloaded, and this is expected to happen with its custom
deleter ReleaseWallet. However, if the chain notifications handler is
still set, then the shared_ptr is still referenced by something, so the
wallet is never actually released.

Backport of core#29243.

Depends on D17981.

This fixes the ASAN failure from the wallet_assumeutxo functional test.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Wed, Apr 23, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 23, 15:25
Fabien requested review of this revision.Wed, Apr 23, 15:25
teamcity edited the summary of this revision. (Show Details)Wed, Apr 23, 15:25
Fabien added a comment.Wed, Apr 23, 15:26

@bot build-asan

teamcity awarded a token.Wed, Apr 23, 15:26
Fabien updated this revision to Diff 53645.Wed, Apr 23, 15:35

Remove another fixme

Fabien added a comment.Wed, Apr 23, 15:35

@bot build-asan

teamcity updated a token.Wed, Apr 23, 15:35
Harbormaster completed remote builds in B33075: Diff 53644.Wed, Apr 23, 15:42
Harbormaster completed remote builds in B33076: Diff 53645.
PiRK accepted this revision.Wed, Apr 23, 16:04
This revision is now accepted and ready to land.Wed, Apr 23, 16:04
Closed by commit rABC5eb5cf6515fe: wallet: Reset chain notifications handler if AttachChain fails (authored by Ava Chow <github@achow101.com>, committed by Fabien). · Explain WhyWed, Apr 23, 18:49
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC5eb5cf6515fe: wallet: Reset chain notifications handler if AttachChain fails.

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
test/
functional/
14 lines

Diff 53645

View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_assumeutxo.py

Loading...