Page MenuHomePhabricator
Differential D17994

rpc: Enhance metadata of the dumptxoutset output
AcceptedPublic
Actions

Authored by PiRK on Thu, Apr 24, 19:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

The following data is added:

  • A newly introduced utxo set magic
  • A version number
  • The network magic
  • The block height

This concludes backport of core#29612
https://github.com/bitcoin/bitcoin/pull/29612/commits/542e13b2937356810bda2c41be83c3b1675e2f2f

Depends on D17989

Test Plan

ninja all check-all

Dump an assumeutxo snapshot on a fully synced node, load it on a fresh new node, let it fully validate the chain

Diff Detail

Event Timeline

PiRK created this revision.Thu, Apr 24, 19:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Apr 24, 19:25
teamcity edited the summary of this revision. (Show Details)Thu, Apr 24, 19:25
Harbormaster completed remote builds in B33099: Diff 53680.Thu, Apr 24, 19:37
PiRK updated this revision to Diff 53684.Fri, Apr 25, 06:13
PiRK edited the test plan for this revision. (Show Details)

remove mentions of signet in logs

PiRK published this revision for review.Fri, Apr 25, 06:13
Harbormaster completed remote builds in B33101: Diff 53684.Fri, Apr 25, 06:25
Fabien accepted this revision.Fri, Apr 25, 09:57
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/kernel/chainparams.cpp
538

This is correct but very confusing. At some point we should have the type differentiated for the disk and network magic bytes

This revision is now accepted and ready to land.Fri, Apr 25, 09:57
Fabien added inline comments.Fri, Apr 25, 10:02
test/functional/feature_assumeutxo.py
113

Revision Contents
Changeset List

PathSize
src/
kernel/
4 lines
27 lines
node/
73 lines
rpc/
23 lines
test/
functional/
89 lines
2 lines

Diff 53684

View Options

src/kernel/chainparams.h

Loading...
View Options

src/kernel/chainparams.cpp

Loading...
View Options

src/node/utxo_snapshot.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

test/functional/feature_assumeutxo.py

Loading...
View Options

test/functional/rpc_dumptxoutset.py

Loading...