Differential D18038

[test] Vote unknown for the elements we don't care in abc_p2p_avalanche_contender_voting
ClosedPublic
Actions

Authored by Fabien on Thu, May 1, 11:27.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC126377f4b3a5: [test] Vote unknown for the elements we don't care in…

Summary

This will avoid finalizing/rejecting inventory items inadvertenly while the test expects to finalize/invalidate only some.

This is a step towards fixing the test flakiness.

Depends on D18037.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Thu, May 1, 11:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, May 1, 11:27

Fabien requested review of this revision.Thu, May 1, 11:27

Harbormaster completed remote builds in B33188: Diff 53808.Thu, May 1, 11:38

Fabien added a child revision: D18039: [test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting.Thu, May 1, 12:03

roqqit accepted this revision.Thu, May 1, 15:53

This revision is now accepted and ready to land.Thu, May 1, 15:53

Closed by commit rABC126377f4b3a5: [test] Vote unknown for the elements we don't care in… (authored by Fabien). · Explain WhyThu, May 1, 16:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC126377f4b3a5: [test] Vote unknown for the elements we don't care in….

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_contender_voting.py

10 lines

test_framework/

avatools.py

4 lines

Diff 53821

View Options

test/functional/abc_p2p_avalanche_contender_voting.py