Differential D18040

[test] Only activate the quorum after all the peers are connected
ClosedPublic
Actions

Authored by Fabien on Thu, May 1, 12:07.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABCf12eb8ee2200: [test] Only activate the quorum after all the peers are connected

Summary

This ensures the proof gets finalized at the same time, avoiding flakiness.

This is a step towards fixint the test flakiness.

Depends on D18039.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_quorum_ratio

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33190
Build 65863: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 65862: arc lint + arc unit

Event Timeline

Fabien created this revision.Thu, May 1, 12:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, May 1, 12:07

Fabien requested review of this revision.Thu, May 1, 12:07

Fabien added a child revision: D18033: [test] Assert the exact list of contenders to be polled in abc_p2p_avalanche_contender_voting.Thu, May 1, 12:14

Harbormaster completed remote builds in B33190: Diff 53810.Thu, May 1, 12:17

roqqit accepted this revision.Thu, May 1, 15:58

This revision is now accepted and ready to land.Thu, May 1, 15:58

Closed by commit rABCf12eb8ee2200: [test] Only activate the quorum after all the peers are connected (authored by Fabien). · Explain WhyThu, May 1, 16:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf12eb8ee2200: [test] Only activate the quorum after all the peers are connected.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_contender_voting.py

9 lines

Diff 53810

View Options

test/functional/abc_p2p_avalanche_contender_voting.py

[test] Only activate the quorum after all the peers are connectedClosedPublicActions