[Cashtab] Set ConnectionStrategy.ClosestFirst for initialization
Needs ReviewPublic
Actions

Authored by alitayin on Thu, May 1, 20:02.

Details

Reviewers

Fabien
bytesofman

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Set ConnectionStrategy.ClosestFirst for initialization chronik-client will start asynchronously and others will wait.

Test Plan

npm test and test it manually in the local demo

Repository

rABC Bitcoin ABC

Branch

alita0501

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Owners added a reviewer: Restricted Owners Package.Thu, May 1, 20:02

alitayin requested review of this revision.Thu, May 1, 20:02

@bot preview-cashtab

emack added inline comments.

cashtab/src/index.tsx
40	Client initialization errors are material enough to be rendered for the user in the frontend rather than a silent console msg.

cashtab/src/index.tsx
40	gm. the console of initialization failure here is my "imagination" because with the current node selection strategy, the worst case scenario is failure after 1000ms, followed by using the default order. So the worst case is consistent with the "original" method. Therefore, the "initialization" failure here might be redundant, or there should be a better description.