Page MenuHomePhabricator

[qa] fix flakiness of bip68-sequence
ClosedPublic

Authored by schancel on Sep 24 2018, 23:00.

Details

Summary

Currently bip68-squence sometimes fails due to an inability to sync blocks.
This is because the block generated in activateCSV is sometimes synced to node1
from node0, and prior to it being invalidated on node0. If this happens, node0
can never sync the tip from node1 (as it has been explicitly invalidated).

The fix is to disconnect the two nodes prior to block generation on node0,
activateCSV, invalidate the block, then sync.

Test Plan
./test/functional/test_runner.py bip68-sequence

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 24 2018, 23:28
schancel added inline comments.
test/functional/bip68-sequence.py
438 ↗(On Diff #5011)

The other possible fix is to make invalidateblock call on both nodes

This revision was automatically updated to reflect the committed changes.