Differential D18052

[electrum] wrap the error message when exchange rate API fails
ClosedPublic
Actions

Authored by PiRK on Tue, May 6, 06:56.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCc362a890c708: [electrum] wrap the error message when exchange rate API fails

Summary

Provide a better user experience by not showing a full python error stack for common URL or JSON errors.
ref T3816

Test Plan

Try loading invoices with various errors (Tools > Invoice > Load and pay invoice).
With the example provided in T3816, replacing "api.binance.com" with "apisdqdsfgsqdg.binance.com" causes a JSONError.
Replacing "symbol=XECUSDT" with "symbol=XECUSGT" causes a HTTPError.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

invoice_errors

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33220
Build 65923: Build Diff	electrum-tests
Build 65922: arc lint + arc unit

Event Timeline

PiRK created this revision.Tue, May 6, 06:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 6, 06:56

PiRK requested review of this revision.Tue, May 6, 06:56

Harbormaster completed remote builds in B33220: Diff 53867.Tue, May 6, 06:58

Fabien accepted this revision.Tue, May 6, 08:00

This revision is now accepted and ready to land.Tue, May 6, 08:00

Closed by commit rABCc362a890c708: [electrum] wrap the error message when exchange rate API fails (authored by PiRK). · Explain WhyTue, May 6, 09:01

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc362a890c708: [electrum] wrap the error message when exchange rate API fails.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

21 lines

electrumabc_gui/

qt/

13 lines

Diff 53867

electrum/electrumabc/invoice.py

Loading...

electrum/electrumabc_gui/qt/main_window.py

Loading...