Paths

Table of Contentst

Differential D18075

clang-tidy: Add `performance-inefficient-vector-operation` check
ClosedPublic
Actions

Authored by PiRK on May 10 2025, 15:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4faf6bb42918: clang-tidy: Add `performance-inefficient-vector-operation` check

Summary

https://clang.llvm.org/extra/clang-tidy/checks/performance/inefficient-vector-operation.html

This is a partial backport of core#26642

Depends on D18074

Test Plan

ninja all check-all bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33270
Build 66022: Build Diff	build-without-wallet · lint-circular-dependencies · build-bench · build-clang-tidy · build-clang · build-debug · build-diff
Build 66021: arc lint + arc unit

Event Timeline

PiRK created this revision.May 10 2025, 15:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 10 2025, 15:29

PiRK requested review of this revision.May 10 2025, 15:29

teamcity edited the summary of this revision. (Show Details)May 10 2025, 15:29

Harbormaster completed remote builds in B33270: Diff 53936.May 10 2025, 15:41

Fabien accepted this revision.May 12 2025, 12:42

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/test/util/net.cpp
18	unrelated, but ok

This revision is now accepted and ready to land.May 12 2025, 12:42

Closed by commit rABC4faf6bb42918: clang-tidy: Add `performance-inefficient-vector-operation` check (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyMay 12 2025, 18:39

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4faf6bb42918: clang-tidy: Add `performance-inefficient-vector-operation` check.

Revision Contents
Changeset List

Path

Size

src/

.clang-tidy

1 line

avalanche/

test/

stakecontendercache_tests.cpp

2 lines

bench/

chained_tx.cpp

7 lines

coin_selection.cpp

1 line

lockedpool.cpp

5 lines

rpc/

server.cpp

2 lines

test/

1 line

1 line

1 line

1 line

2 lines

script_p2sh_tests.cpp

4 lines

txrequest_tests.cpp

1 line

util/

net.cpp

5 lines

util_threadnames_tests.cpp

1 line

validation_block_tests.cpp

1 line

wallet/

bdb.cpp

1 line

rpc/

backup.cpp

1 line

scriptpubkeyman.cpp

1 line

Diff 53936

View Options

src/.clang-tidy

View Options

src/avalanche/test/stakecontendercache_tests.cpp

View Options

src/bench/chained_tx.cpp

View Options

src/bench/coin_selection.cpp

View Options

src/bench/lockedpool.cpp

View Options

src/rpc/server.cpp

View Options

src/test/allocator_tests.cpp

View Options

src/test/getarg_tests.cpp

View Options

src/test/mempool_tests.cpp

View Options

src/test/radix_tests.cpp

View Options

src/test/scheduler_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

View Options

src/test/txrequest_tests.cpp

View Options

src/test/util/net.cpp

View Options

src/test/util_threadnames_tests.cpp

View Options

src/test/validation_block_tests.cpp

View Options

src/wallet/bdb.cpp

View Options

src/wallet/rpc/backup.cpp

View Options

src/wallet/scriptpubkeyman.cpp

clang-tidy: Add `performance-inefficient-vector-operation` checkClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53936

src/.clang-tidy

src/avalanche/test/stakecontendercache_tests.cpp

src/bench/chained_tx.cpp

src/bench/coin_selection.cpp

src/bench/lockedpool.cpp

src/rpc/server.cpp

src/test/allocator_tests.cpp

src/test/getarg_tests.cpp

src/test/mempool_tests.cpp

src/test/radix_tests.cpp

src/test/scheduler_tests.cpp

src/test/script_p2sh_tests.cpp

src/test/txrequest_tests.cpp

src/test/util/net.cpp

src/test/util_threadnames_tests.cpp

src/test/validation_block_tests.cpp

src/wallet/bdb.cpp

src/wallet/rpc/backup.cpp

src/wallet/scriptpubkeyman.cpp

clang-tidy: Add `performance-inefficient-vector-operation` check
ClosedPublic
Actions

Revision Contents
Changeset List