Differential D18077

Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint"
ClosedPublic
Actions

Authored by Fabien on Mon, May 12, 13:11.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCcdb17840db55: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint"

Summary

This reverts commit rABC9b02451660e2d4aa2b1394a4ece44e58981bb494.

There is a subtle difference in the notification format vs Fulcrum that I missed, this needs to be fixed.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

revert_electrum_headers_subscribe

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33275
Build 66032: Build Diff	chronik-client-integration-tests · ecash-lib-integration-tests · ecash-agora-integration-tests · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-chronik-plugins · build-chronik
Build 66031: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, May 12, 13:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 12, 13:11

Fabien requested review of this revision.Mon, May 12, 13:11

Fabien planned changes to this revision.Mon, May 12, 13:12

Harbormaster completed remote builds in B33275: Diff 53942.Mon, May 12, 13:37

Fabien requested review of this revision.Mon, May 12, 14:29

Fabien edited the summary of this revision. (Show Details)

PiRK accepted this revision.Mon, May 12, 14:30

This revision is now accepted and ready to land.Mon, May 12, 14:30

Closed by commit rABCcdb17840db55: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint" (authored by Fabien). · Explain WhyMon, May 12, 14:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcdb17840db55: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".

Revision Contents
Changeset List

Path

Size

chronik/

chronik-http/

src/

104 lines

test/

functional/

chronik_electrum_blockchain.py

64 lines

test_framework/

jsonrpctools.py

42 lines

Diff 53942

chronik/chronik-http/src/electrum.rs

Loading...

test/functional/chronik_electrum_blockchain.py

Loading...

test/functional/test_framework/jsonrpctools.py

Loading...