Page MenuHomePhabricator
Differential D18081

Remove c++20 header
ClosedPublic
Actions

Authored by Fabien on Mon, May 12, 19:34.

Details

Reviewers
PiRK
roqqit
Group Reviewers
Restricted Project
Commits
rABCd9414bd7cdc0: Remove c++20 header
Summary

We don't enforce c++20 (yet) so we shouldn't include any c++20 header to avoid breaking the build on older supported compilers.
D17964 avoided the use of std::countr_zero because it's c++20, but the <bit> header was still included.

Test Plan
ninja all check

Diff Detail

Event Timeline

Fabien created this revision.Mon, May 12, 19:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 12, 19:34
Fabien requested review of this revision.Mon, May 12, 19:34
Harbormaster completed remote builds in B33279: Diff 53955.Mon, May 12, 19:48
PiRK accepted this revision.Mon, May 12, 20:11
This revision is now accepted and ready to land.Mon, May 12, 20:11
roqqit accepted this revision.Mon, May 12, 20:55
roqqit added a subscriber: roqqit.

builds on Debian 10 (buster) with gcc 8.3

Closed by commit rABCd9414bd7cdc0: Remove c++20 header (authored by Fabien). · Explain WhyMon, May 12, 21:50
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd9414bd7cdc0: Remove c++20 header.

Revision Contents
Changeset List

PathSize
src/
crypto/
1 line

Diff 53955

View Options

src/crypto/muhash.cpp

Loading...