Differential D18097

[chronik] Electrum: handle multiple messages in a single packet in the test framework
ClosedPublic
Actions

Authored by Fabien on Thu, May 15, 14:30.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC46f7816d9a73: [chronik] Electrum: handle multiple messages in a single packet in the test…

Summary

It is possible for the server to send several '\n' separated messages in a single data frame. This diff adds support for this. For the current tests there is no change in behavior.

Test Plan

./test/functional/test_runner.py chronik_electrum_*

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Thu, May 15, 14:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, May 15, 14:30

Fabien requested review of this revision.Thu, May 15, 14:30

Fabien mentioned this in D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

Fabien added a child revision: D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.Thu, May 15, 14:31

Harbormaster completed remote builds in B33318: Diff 54009.Thu, May 15, 14:57

PiRK added a subscriber: PiRK.Thu, May 15, 15:12

PiRK added inline comments.

test/functional/test_framework/jsonrpctools.py
120–129 ↗	(On Diff #54009)	I probably doesn't matter much for the tests, but we could implement this a bit more efficiently by avoiding the split/join round trip. See https://www.w3schools.com/python/trypython.asp?filename=demo_ref_string_split4 (untested)