Page MenuHomePhabricator

[depends] Backport various changes to Qt build
ClosedPublic

Authored by deadalnix on Sep 26 2018, 17:09.

Details

Summary
  • [Depends] Fix Qt build with Xcode 9.2 (PR11995)
  • depends: Fix Qt build with XCode 9.3 (PR12946)
  • depends: Update Qt download url (PR13544)
Test Plan
make -C ../depends build-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
dependsqtupdate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3383
Build 4847: Bitcoin ABC Buildbot (legacy)
Build 4846: arc lint + arc unit

Event Timeline

jasonbcox added a subscriber: jasonbcox.

This change looks relatively benign, but I don't really know the specifics of what it accomplishes. I would prefer review by someone more knowledgeable about building with XCode, but I don't think we have such a person.

This revision is now accepted and ready to land.Sep 26 2018, 18:49
This revision was automatically updated to reflect the committed changes.