Differential D18121

[bitcoinsuite-core] Fix a potential out of bounds access during address decoding
ClosedPublic
Actions

Authored by Fabien on May 20 2025, 22:09.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4b06f0204216: [bitcoinsuite-core] Fix a potential out of bounds access during address decoding

Summary

The code expects the checksum to be present and will cause the slice to access out of bounds otherwise. This diff changes to logic to verify the checksum first so this can't happen anymore.

Test Plan

ninja check-crate-bitcoinsuite-core

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 20 2025, 22:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2025, 22:09

Fabien requested review of this revision.May 20 2025, 22:09

Fabien added a child revision: D18122: [chronik] Electrum: support prefixless addresses.May 20 2025, 22:14

Harbormaster completed remote builds in B33390: Diff 54110.May 20 2025, 22:26

PiRK accepted this revision.May 21 2025, 07:54

This revision is now accepted and ready to land.May 21 2025, 07:54

Closed by commit rABC4b06f0204216: [bitcoinsuite-core] Fix a potential out of bounds access during address decoding (authored by Fabien). · Explain WhyMay 21 2025, 13:03

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4b06f0204216: [bitcoinsuite-core] Fix a potential out of bounds access during address decoding.

Revision Contents
Changeset List

Path

Size

chronik/

bitcoinsuite-core/

src/

address.rs

25 lines

Diff 54114

View Options

chronik/bitcoinsuite-core/src/address.rs

[bitcoinsuite-core] Fix a potential out of bounds access during address decodingClosedPublicActions