Page MenuHomePhabricator

[test] add a verbose logger to ChronikElectrumClient
ClosedPublic

Authored by PiRK on May 22 2025, 20:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfcfc6e89405b: [test] add a verbose logger to ChronikElectrumClient
Summary

This will help troubleshoot test failures related to unexpected notifications and multiple clients.
The logger can use an optional name passed to the ChronikElectrumClient.__init__ method for easier debugging. By default this "name" is a unique number.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronikelectrummaxhistory_typo
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33403
Build 66285: Build Diffbuild-debug · build-clang-tidy · build-clang · build-diff · build-without-wallet
Build 66284: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.May 22 2025, 20:46
test/functional/test_framework/jsonrpctools.py
93

By prefixing the logger name with "TestFramework." we inherit the settings (logging level, output file...) of the parent logger defined in test_framework.py

make comment a proper sentence

This revision is now accepted and ready to land.May 23 2025, 08:04