qt: Do not assume `qDBusRegisterMetaType` return type
ClosedPublic
Actions

Authored by PiRK on May 24 2025, 15:47.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC826973909760: qt: Do not assume `qDBusRegisterMetaType` return type

Summary

qDBusRegisterMetaType returns:

int in Qt 5
QMetaType in Qt 6

This is a backport of core#584
Depends on D18140

Test Plan

ninja all check-all

Not sure how to trigger that code path interactively. The change is probably trivial enough to assume it just works (we just inlined an unnecessary wrapper function).

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 24 2025, 15:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2025, 15:47

PiRK requested review of this revision.May 24 2025, 15:47

teamcity edited the summary of this revision. (Show Details)May 24 2025, 15:47

PiRK edited the test plan for this revision. (Show Details)May 24 2025, 15:48

Harbormaster completed remote builds in B33422: Diff 54160.May 24 2025, 16:00

Fabien accepted this revision.May 26 2025, 09:27

This revision is now accepted and ready to land.May 26 2025, 09:27

Closed by commit rABC826973909760: qt: Do not assume `qDBusRegisterMetaType` return type (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyMay 26 2025, 09:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC826973909760: qt: Do not assume `qDBusRegisterMetaType` return type.

Revision Contents
Changeset List

Path

Size

src/

qt/

notificator.cpp

9 lines

Diff 54186

View Options

qt: Do not assume `qDBusRegisterMetaType` return typeClosedPublicActions