Page MenuHomePhabricator
Differential D18145

qt: make BitcoinGui::config a const ref
ClosedPublic
Actions

Authored by PiRK on May 26 2025, 08:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC68514a0d2cc5: qt: make BitcoinGui::config a const ref
Summary

The callsites all assume that config is never a nullptr, so enforce it by using a const reference rather than a bare pointer.

Test Plan

ninja all check-all

run bitcoin-qt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 26 2025, 08:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2025, 08:23
PiRK requested review of this revision.May 26 2025, 08:23
Harbormaster completed remote builds in B33432: Diff 54173.May 26 2025, 08:38
PiRK retitled this revision from gui: make BitcoinGui::config a const ref to qt: make BitcoinGui::config a const ref.May 26 2025, 08:53
Fabien accepted this revision.May 26 2025, 09:29
This revision is now accepted and ready to land.May 26 2025, 09:29
Closed by commit rABC68514a0d2cc5: qt: make BitcoinGui::config a const ref (authored by PiRK). · Explain WhyMay 26 2025, 13:35
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC68514a0d2cc5: qt: make BitcoinGui::config a const ref.

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
4 lines
4 lines
10 lines
test/
2 lines

Diff 54189

View Options

src/qt/bitcoin.h

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/test/apptests.cpp

Loading...