Page MenuHomePhabricator

Fix fee estimate rounding errors
ClosedPublic

Authored by schancel on Sep 27 2018, 00:07.

Details

Summary

Fixes an issue that has been brought up where fees were truncated down during estimation,
causing the estimatefee rpc to return values less than the current minimum relay feerate.

We replace default truncation with mathimatical ceilings everywhere relevant for estimating
a fee to be paid. Note well: we leave all minimum calculation alone so as to not underbill
by accident.

Builds on D1670

Inspired by Core PR 11303 by Matt Corallo.

Test Plan
make VERBOSE=1 check && ./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Clean up some extraneous changes

Thanks sublime text and your smart parens.

This revision is now accepted and ready to land.Sep 27 2018, 11:44
This revision was automatically updated to reflect the committed changes.
schancel marked an inline comment as done.