Page MenuHomePhabricator
Differential D18169

[chronik] Electrum: Implement the blockchain.header.get endpoint
ClosedPublic
Actions

Authored by Fabien on May 28 2025, 21:04.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC7507d19d8cfc: [chronik] Electrum: Implement the blockchain.header.get endpoint
Summary

https://electrum-cash-protocol.readthedocs.io/en/latest/protocol-methods.html#blockchain.header.get

The boring part is to get the errors to align with Fulcrum.

Depends on D18167.

Test Plan
./test/functional/test_runner.py chronik_electrum_blockchain

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 28 2025, 21:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2025, 21:04
Fabien requested review of this revision.May 28 2025, 21:04
Harbormaster completed remote builds in B33469: Diff 54240.May 28 2025, 21:27
PiRK requested changes to this revision.May 29 2025, 09:40
PiRK added a subscriber: PiRK.

almost LGTM

chronik/chronik-http/src/electrum.rs
2055–2105 ↗(On Diff #54240)

delete

This revision now requires changes to proceed.May 29 2025, 09:40
Fabien added inline comments.May 29 2025, 14:23
chronik/chronik-http/src/electrum.rs
2055–2105 ↗(On Diff #54240)

Jeez I should not skip the self review...

Fabien updated this revision to Diff 54242.May 29 2025, 14:23

Remove commented code

PiRK accepted this revision.May 29 2025, 14:25
This revision is now accepted and ready to land.May 29 2025, 14:25
Fabien updated this revision to Diff 54245.May 29 2025, 14:25

Rebase

Harbormaster completed remote builds in B33471: Diff 54242.May 29 2025, 14:45
Harbormaster completed remote builds in B33472: Diff 54245.May 29 2025, 14:58
Closed by commit rABC7507d19d8cfc: [chronik] Electrum: Implement the blockchain.header.get endpoint (authored by Fabien). · Explain WhyMay 29 2025, 20:22
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7507d19d8cfc: [chronik] Electrum: Implement the blockchain.header.get endpoint.

Revision Contents
Changeset List

PathSize
chronik/
chronik-http/
src/
78 lines
test/
functional/
64 lines

Diff 54247

View Options

chronik/chronik-http/src/electrum.rs

Loading...
View Options

test/functional/chronik_electrum_blockchain.py

Loading...