Make sure to fund transactions with a ceil'd result
ClosedPublic
Actions

Authored by schancel on Sep 27 2018, 00:12.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1254f95f79ec: Make sure to fund transactions with a ceil'd result
rABC1254f95f79ec: Make sure to fund transactions with a ceil'd result

Summary

The wallet code failed to be updated to use GetFeeCeiling everywhere needed.
This patch fixes a few more locations so that CreateTransaction does not
end up generating a transaction with insufficient fee.

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

more-ceiling

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3399
Build 4876: Bitcoin ABC Buildbot (legacy)
Build 4875: arc lint + arc unit

Event Timeline

schancel created this revision.Sep 27 2018, 00:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2018, 00:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel edited the test plan for this revision. (Show Details)Sep 27 2018, 00:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3399: Diff 5092.Sep 27 2018, 00:30

schancel retitled this revision from Make sure to fund transactions with ceiling to Make sure to fund transactions with a ceil'd result.Sep 27 2018, 03:12

deadalnix accepted this revision.Sep 27 2018, 12:32

This revision is now accepted and ready to land.Sep 27 2018, 12:32

Closed by commit rABC1254f95f79ec: Make sure to fund transactions with a ceil'd result (authored by schancel). · Explain WhySep 27 2018, 23:21

This revision was automatically updated to reflect the committed changes.