Page MenuHomePhabricator
Differential D18191

[chronik] Electrum: fix txid vs tx_hash the parameter name
ClosedPublic
Actions

Authored by Fabien on Jun 3 2025, 16:17.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC2d4f45ccae71: [chronik] Electrum: fix txid vs tx_hash the parameter name
Summary

The protocol uses tx_hash instead of txid so we use that to remain compatible with clients using named arguments.

Test Plan
./test/functional/test_runner.py chronik_electrum_*

Diff Detail

Event Timeline

Fabien created this revision.Jun 3 2025, 16:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2025, 16:17
Fabien requested review of this revision.Jun 3 2025, 16:17
Fabien added a child revision: D18192: [chronik] Electrum: add the blockchain.transaction.get_confirmed_blockhash endpoint.
Harbormaster completed remote builds in B33510: Diff 54308.Jun 3 2025, 16:46
bytesofman accepted this revision.Jun 3 2025, 18:31
bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
chronik/chronik-http/src/electrum.rs
1489

was this working before this diff? why?

This revision is now accepted and ready to land.Jun 3 2025, 18:31
Fabien added inline comments.Jun 3 2025, 20:40
chronik/chronik-http/src/electrum.rs
1489

yes it worked, the parameter is simply renamed to match the protocol. Apart from the renaming there is no change in behavior

Closed by commit rABC2d4f45ccae71: [chronik] Electrum: fix txid vs tx_hash the parameter name (authored by Fabien). · Explain WhyJun 3 2025, 20:41
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC2d4f45ccae71: [chronik] Electrum: fix txid vs tx_hash the parameter name.

Revision Contents
Changeset List

PathSize
chronik/
chronik-http/
src/
8 lines
test/
functional/
26 lines

Diff 54308

View Options

chronik/chronik-http/src/electrum.rs

Loading...
View Options

test/functional/chronik_electrum_blockchain.py

Loading...