Differential D18192

[chronik] Electrum: add the blockchain.transaction.get_confirmed_blockhash endpoint
ClosedPublic
Actions

Authored by Fabien on Jun 3 2025, 16:18.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCac6ab27a92d0: [chronik] Electrum: add the blockchain.transaction.get_confirmed_blockhash…

Summary

https://electrum-cash-protocol.readthedocs.io/en/latest/protocol-methods.html#blockchain-transaction-get-confirmed-blockhash

Depends on D18191.

Test Plan

./test/functional/test_runner.py chronik_electrum_blockchain

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik_get_confirmed_blockhash

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33511
Build 66501: Build Diff	chronik-client-integration-tests · ecash-lib-integration-tests · ecash-agora-integration-tests · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang · build-chronik-plugins · build-chronik
Build 66500: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 3 2025, 16:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2025, 16:18

Fabien requested review of this revision.Jun 3 2025, 16:18

Fabien added a child revision: D18193: [chronik] Electrum: implement the blockchain.transaction.id_from_pos endpoint.

Harbormaster completed remote builds in B33511: Diff 54309.Jun 3 2025, 16:47

bytesofman requested changes to this revision.Jun 3 2025, 18:32

bytesofman added a subscriber: bytesofman.

bytesofman added inline comments.

chronik/chronik-http/src/electrum.rs
1504	if some error / validation conditions are untested, should have either a test or a rationale for why it's untested

This revision now requires changes to proceed.Jun 3 2025, 18:32

Add missing test case

bytesofman accepted this revision.Jun 3 2025, 20:45

This revision is now accepted and ready to land.Jun 3 2025, 20:45

Harbormaster completed remote builds in B33514: Diff 54313.Jun 3 2025, 21:10

Closed by commit rABCac6ab27a92d0: [chronik] Electrum: add the blockchain.transaction.get_confirmed_blockhash… (authored by Fabien). · Explain WhyJun 3 2025, 21:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCac6ab27a92d0: [chronik] Electrum: add the blockchain.transaction.get_confirmed_blockhash….

Revision Contents
Changeset List

Path

Size

chronik/

chronik-http/

src/

71 lines

test/

functional/

chronik_electrum_blockchain.py

74 lines

test_framework/

1 line

Diff 54309

chronik/chronik-http/src/electrum.rs

Loading...

test/functional/chronik_electrum_blockchain.py

Loading...

test/functional/test_framework/blocktools.py

Loading...