Page MenuHomePhabricator

lint: Fix lint-format-strings false positives when format specifiers have argument positions
ClosedPublic

Authored by PiRK on Jun 7 2025, 10:01.

Details

Summary

Do not error on valid format specifications like strprintf("arg2=%2$s arg1=%1$s arg2=%2$s", arg1, arg2);

Some existing doctests need to be modified to use valid format specifiers (%b and %z do not exist)

This is a partial backport of core#27302.
https://github.com/bitcoin/bitcoin/pull/27302/commits/398c3719b02197ad92fded20f6ff83b364747297

Test Plan

arc lint

python -m doctest test/lint/lint-format-strings.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable