Differential D18241

Use designated initializers for NodeEvictionCandidate
ClosedPublic
Actions

Authored by PiRK on Jun 12 2025, 09:52.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC340f942af629: Use designated initializers for NodeEvictionCandidate

Summary

This concludes backport of core#25472 (bypasses core#24531)
Note that we already use designated initializers for mempool_opts in our codebase

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr27257

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33605
Build 66689: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-clang-tidy · build-debug
Build 66688: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 12 2025, 09:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2025, 09:52

PiRK requested review of this revision.Jun 12 2025, 09:52

teamcity edited the summary of this revision. (Show Details)Jun 12 2025, 09:52

Harbormaster completed remote builds in B33605: Diff 54452.Jun 12 2025, 10:07

PiRK added a child revision: D18242: [net] Add NoBan status and connection type to NodeEvictionCandidate.Jun 12 2025, 10:31

Fabien accepted this revision.Jun 12 2025, 12:50

This revision is now accepted and ready to land.Jun 12 2025, 12:50

Closed by commit rABC340f942af629: Use designated initializers for NodeEvictionCandidate (authored by PiRK). · Explain WhyJun 12 2025, 14:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC340f942af629: Use designated initializers for NodeEvictionCandidate.

Revision Contents
Changeset List

Path

Size

src/

net.cpp

33 lines

Diff 54452

View Options

Use designated initializers for NodeEvictionCandidateClosedPublicActions