Page MenuHomePhabricator
Differential D18244

net: simplify the call to vProcessMsg.splice()
ClosedPublic
Actions

Authored by PiRK on Jun 12 2025, 10:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd492f70d97d3: net: simplify the call to vProcessMsg.splice()
Summary

At the time when

cpp
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg, pnode->vRecvMsg.begin(), it);

is called, it is certainly pnode->vRecvMsg.end() which makes the
call equivalent to:

cpp
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg, pnode->vRecvMsg.begin(), pnode->vRecvMsg.end());

which is equivalent to:

cpp
pnode->vProcessMsg.splice(pnode->vProcessMsg.end(), pnode->vRecvMsg);

Thus, use the latter. Further, maybe irrelevant, but the latter has
constant complexity while the original code is O(length of vRecvMsg).

This is a backport of core#26888
Depends on D18243

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 12 2025, 10:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2025, 10:59
PiRK requested review of this revision.Jun 12 2025, 10:59
teamcity edited the summary of this revision. (Show Details)Jun 12 2025, 10:59
Harbormaster completed remote builds in B33609: Diff 54456.Jun 12 2025, 11:02
teamcity added a comment.Jun 12 2025, 11:02
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[400/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[401/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[402/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[403/586] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o
[404/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[405/586] Building CXX object src/CMakeFiles/server.dir/node/blockstorage.cpp.o
[406/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[407/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[408/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[409/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[410/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[411/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[412/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[413/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[414/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[415/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[416/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[417/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[418/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[419/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[420/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[421/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[422/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[423/586] Building CXX object src/CMakeFiles/server.dir/avalanche/processor.cpp.o
[424/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[425/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[426/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[427/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[428/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[429/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[430/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[431/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[432/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[433/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[434/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[435/586] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[436/586] Linking CXX static library src/wallet/libwallet.a
[437/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[440/586] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[441/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[442/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[443/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[444/586] Linking CXX executable src/iguana/iguana
[445/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[446/586] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[447/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[448/586] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[449/586] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[450/586] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[451/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[452/586] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[453/586] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[454/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[455/586] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[456/586] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[457/586] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Jun 12 2025, 11:03
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[400/586] Linking C executable src/secp256k1/internal-bench
[401/586] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[402/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[403/586] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[404/586] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[405/586] Linking CXX executable src/bitcoin-cli
[406/586] Linking C executable src/secp256k1/ecmult-bench
[407/586] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[408/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[409/586] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[410/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[411/586] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[412/586] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[413/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[414/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[415/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[416/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[417/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[418/586] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[419/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[420/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[421/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[422/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[423/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[424/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[425/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[426/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[427/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[428/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[429/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[430/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[431/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[432/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[433/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[434/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[435/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[436/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[437/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[438/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[439/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[440/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[441/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[442/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[443/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[444/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[445/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[446/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[447/586] Linking CXX executable src/iguana/iguana
[448/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[449/586] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[450/586] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[451/586] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[452/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[453/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[454/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[455/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[456/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[457/586] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
teamcity added a comment.Jun 12 2025, 11:03
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[399/584] Linking CXX executable src/bitcoin-tx
[400/584] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[401/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[402/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[403/584] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[404/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[405/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[406/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[407/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[408/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[409/584] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[410/584] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[411/584] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[412/584] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[413/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[414/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[415/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[416/584] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[417/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[418/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[419/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[420/584] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[421/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[422/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[423/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[424/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[425/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[426/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[427/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[428/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[429/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[430/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[431/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[432/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[433/584] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[434/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[435/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[436/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[437/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[438/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[440/584] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[441/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[442/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[443/584] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[444/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[445/584] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[446/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[447/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[448/584] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[449/584] Linking CXX executable src/iguana/iguana
[450/584] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[451/584] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[452/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[453/584] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[454/584] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[455/584] Linking CXX static library src/wallet/libwallet.a
[456/584] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Jun 12 2025, 11:03
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[522/663] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[523/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/stakecontendercache.cpp.o
[524/663] Linking C executable src/secp256k1/sign-bench
[525/663] Linking CXX static library src/libcommon.a
[526/663] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[527/663] Linking CXX shared library src/libbitcoinconsensus.so.0.31.6
[528/663] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[529/663] Linking CXX executable src/bitcoin-cli
[530/663] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[531/663] Linking C executable src/secp256k1/ecmult-bench
[532/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/node/blockstorage.cpp.o
[533/663] Linking CXX executable src/bitcoin-tx
[534/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[535/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/stakingrewards.cpp.o
[536/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[537/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/txmempool.cpp.o
[538/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[539/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[540/663] Building CXX object src/CMakeFiles/bitcoin-chainstate.dir/bitcoin-chainstate.cpp.o
[541/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[542/663] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[543/663] Linking C executable src/secp256k1/internal-bench
[544/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[545/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[546/663] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[547/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[548/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[549/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/peermanager.cpp.o
[550/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[551/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/processor.cpp.o
[552/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[553/663] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[554/663] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[555/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/net.cpp.o
FAILED: src/CMakeFiles/bitcoinkernel.dir/net.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_CONFIG_H -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/src/leveldb/helpers/memenv -I/work/abc-ci-builds/build-without-wallet/src -I/work/abc-ci-builds/build-without-wallet/src/crypto/.. -I/work/src/univalue/include -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++17 -MD -MT src/CMakeFiles/bitcoinkernel.dir/net.cpp.o -MF src/CMakeFiles/bitcoinkernel.dir/net.cpp.o.d -o src/CMakeFiles/bitcoinkernel.dir/net.cpp.o -c /work/src/net.cpp
In file included from /work/src/net.cpp:10:
/work/src/./net.h: In constructor ‘CNode::CNode(NodeId, std::shared_ptr<Sock>, const CAddress&, uint64_t, uint64_t, uint64_t, const CAddress&, const std::string&, ConnectionType, bool, CNodeOptions&&)’:
/work/src/./net.h:714:20: error: ‘CNode::nLocalExtraEntropy’ will be initialized after [-Werror=reorder]
  714 |     const uint64_t nLocalExtraEntropy;
      |                    ^~~~~~~~~~~~~~~~~~
/work/src/./net.h:463:26: error:   ‘const ConnectionType CNode::m_conn_type’ [-Werror=reorder]
  463 |     const ConnectionType m_conn_type;
      |                          ^~~~~~~~~~~
/work/src/net.cpp:2975:1: error:   when initialized here [-Werror=reorder]
 2975 | CNode::CNode(NodeId idIn, std::shared_ptr<Sock> sock, const CAddress &addrIn,
      | ^~~~~
cc1plus: all warnings being treated as errors
[556/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[557/663] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[558/663] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[559/663] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[560/663] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[561/663] Linking CXX executable src/iguana/iguana
[562/663] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[563/663] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[564/663] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[565/663] Building CXX object src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Jun 12 2025, 11:04
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[400/586] Linking CXX shared library src/libbitcoinconsensus.so.0.31.6
[401/586] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[402/586] Linking CXX executable src/bitcoin-cli
[403/586] Linking CXX executable src/bitcoin-tx
[404/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[405/586] Building CXX object src/CMakeFiles/server.dir/avalanche/processor.cpp.o
[406/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[407/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[408/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[409/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[410/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[411/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[412/586] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[413/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[414/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[415/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[416/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[417/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[418/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[419/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[420/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[421/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[422/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[423/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[424/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[425/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[426/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[427/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[428/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[429/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[430/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[431/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[432/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[433/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[434/586] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[435/586] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[436/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[437/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[439/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[440/586] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[441/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[442/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[443/586] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[444/586] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o
[445/586] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[446/586] Linking CXX static library src/wallet/libwallet.a
[447/586] Linking CXX executable src/iguana/iguana
[448/586] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[449/586] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[450/586] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[451/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[452/586] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[453/586] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[454/586] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[455/586] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[456/586] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[457/586] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
PiRK added a child revision: D18245: net: remove misplaced and outdated comment.Jun 12 2025, 11:22
Fabien requested changes to this revision.Jun 12 2025, 12:55
Fabien added a subscriber: Fabien.

The build is broken

This revision now requires changes to proceed.Jun 12 2025, 12:55
PiRK updated this revision to Diff 54462.Jun 12 2025, 14:26

rebase. The error is caused by another commit (not yet submitted as a diff)

Harbormaster completed remote builds in B33612: Diff 54462.Jun 12 2025, 14:47
Fabien accepted this revision.Jun 12 2025, 19:56
This revision is now accepted and ready to land.Jun 12 2025, 19:56
Closed by commit rABCd492f70d97d3: net: simplify the call to vProcessMsg.splice() (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyJun 13 2025, 05:36
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd492f70d97d3: net: simplify the call to vProcessMsg.splice().

Revision Contents
Changeset List

PathSize
src/
9 lines
test/
util/
8 lines

Diff 54466

View Options

src/net.cpp

Loading...
View Options

src/test/util/net.cpp

Loading...