Differential D18246

[chronik] Electrum: implement the mempool.get_fee_histogram() endpoint
ClosedPublic
Actions

Authored by Fabien on Jun 12 2025, 12:49.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5c6394a11a86: [chronik] Electrum: implement the mempool.get_fee_histogram() endpoint

Summary

https://electrum-cash-protocol.readthedocs.io/en/latest/protocol-methods.html#mempool-get-fee-histogram

We simply use powers of 2 as a fee rate interval, which seems to be what fulcrum does. Note that the unit is sat/vB.

Test Plan

./test/functional/test_runner.py chronik_electrum_blockchain

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 12 2025, 12:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2025, 12:49

Fabien requested review of this revision.Jun 12 2025, 12:49

Harbormaster completed remote builds in B33611: Diff 54458.Jun 12 2025, 13:08

Looks good.

Putting holes in the histogram is debatable and may require some documentation (vs just putting the value vsize = 0 explicitly in the output, which would make the fee-ranges a bit more self-explanatory). But I don't plan to use this for now, so not blocking on it. And we need some doc anyway to inform users that the fee value is the max value of the range.

This revision is now accepted and ready to land.Jun 12 2025, 14:49

In D18246#415951, @PiRK wrote:

Looks good.

Putting holes in the histogram is debatable and may require some documentation (vs just putting the value vsize = 0 explicitly in the output, which would make the fee-ranges a bit more self-explanatory). But I don't plan to use this for now, so not blocking on it. And we need some doc anyway to inform users that the fee value is the max value of the range.

You can see it as merging intervals rather than a "hole"...
This mimics the behavior of fulcrum afaict

Closed by commit rABC5c6394a11a86: [chronik] Electrum: implement the mempool.get_fee_histogram() endpoint (authored by Fabien). · Explain WhyJun 12 2025, 19:51

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5c6394a11a86: [chronik] Electrum: implement the mempool.get_fee_histogram() endpoint.