Page MenuHomePhabricator
Differential D18259

refactor: Split InterpretOption into Interpret{Key,Value} functions
ClosedPublic
Actions

Authored by PiRK on Jun 16 2025, 12:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC31a27f56d4f0: refactor: Split InterpretOption into Interpret{Key,Value} functions
Summary

Co-authored-by: Anthony Towns <aj@erisian.com.au>

This is a partial backport of core#22766
https://github.com/bitcoin/bitcoin/pull/22766/commits/26a50ab322614bceb5bc62e2c282f83e5987bad8

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 16 2025, 12:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2025, 12:14
PiRK requested review of this revision.Jun 16 2025, 12:14
teamcity edited the summary of this revision. (Show Details)Jun 16 2025, 12:14
PiRK added a child revision: D18260: refactor: Add explicit DISALLOW_NEGATION ArgsManager flag to clarify flag usage.Jun 16 2025, 12:20
Harbormaster completed remote builds in B33635: Diff 54494.Jun 16 2025, 12:35
PiRK updated this revision to Diff 54496.Jun 16 2025, 12:38

remove unused function declarations. In the source material these did not exist because the functions were used as static (out of order backports, args.cpp split into multiple submodules)

Harbormaster completed remote builds in B33637: Diff 54496.Jun 16 2025, 12:49
Fabien accepted this revision.Jun 17 2025, 08:10
This revision is now accepted and ready to land.Jun 17 2025, 08:10
Closed by commit rABC31a27f56d4f0: refactor: Split InterpretOption into Interpret{Key,Value} functions (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyJun 17 2025, 13:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC31a27f56d4f0: refactor: Split InterpretOption into Interpret{Key,Value} functions.

Revision Contents
Changeset List

PathSize
src/
common/
18 lines
79 lines
13 lines

Diff 54511

View Options

src/common/args.h

Loading...
View Options

src/common/args.cpp

Loading...
View Options

src/common/configfile.cpp

Loading...