Make bitcoind invalid argument error message specific
ClosedPublic
Actions

Authored by deadalnix on Sep 28 2018, 11:14.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING41e08b12e886: Make bitcoind invalid argument error message specific
rABC41e08b12e886: Make bitcoind invalid argument error message specific

Summary

The current message is not helpful. Hardly anyone even remembers that
bitcoind used to be a cli utility, let alone new users. Print what the
actual problem is.

This is a backport of Core's PR10447

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 28 2018, 11:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2018, 11:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3427: Diff 5149.Sep 28 2018, 11:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Sep 28 2018, 17:31

This revision is now accepted and ready to land.Sep 28 2018, 17:31

Closed by commit rABC41e08b12e886: Make bitcoind invalid argument error message specific (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by deadalnix). · Explain WhySep 28 2018, 19:16

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

bitcoind.cpp

24 lines

Diff 5163

View Options

Make bitcoind invalid argument error message specificClosedPublicActions