Differential D18298

[chronik] Electrum: Fix misnamed ssl_port field
ClosedPublic
Actions

Authored by Fabien on Jun 27 2025, 09:55.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCfdc8abc3523e: [chronik] Electrum: Fix misnamed ssl_port field

Summary

The protocol defines this feature field as ssl_port and not tls_port.

This was untested because we don't have tools for connecting via TLS with the test framework, and poped when testing the peer validation.

Test Plan

./test/functional/test_runner.py chronik_electrum_basic

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 27 2025, 09:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2025, 09:55

Fabien requested review of this revision.Jun 27 2025, 09:55

Fabien added a child revision: D18297: [chronik] Electrum: Implement peer validation.Jun 27 2025, 10:04

PiRK accepted this revision.Jun 27 2025, 10:15

This revision is now accepted and ready to land.Jun 27 2025, 10:15

Harbormaster completed remote builds in B33703: Diff 54602.Jun 27 2025, 10:28

Closed by commit rABCfdc8abc3523e: [chronik] Electrum: Fix misnamed ssl_port field (authored by Fabien). · Explain WhyJun 27 2025, 12:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfdc8abc3523e: [chronik] Electrum: Fix misnamed ssl_port field.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-http/

src/

electrum.rs

2 lines

Diff 54607

View Options

chronik/chronik-http/src/electrum.rs

[chronik] Electrum: Fix misnamed ssl_port fieldClosedPublicActions