Page MenuHomePhabricator
Differential D18312

test: Move P2SH_OP_TRUE to shared test library
ClosedPublic
Actions

Authored by Fabien on Jul 2 2025, 15:15.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC2df009ca6b64: test: Move P2SH_OP_TRUE to shared test library
Summary

Otherwise it can't be used in other tests (unit, fuzz, bench, ...)

Backport of core#21211.

Test Plan
ninja check

Diff Detail

Event Timeline

Fabien created this revision.Jul 2 2025, 15:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2025, 15:15
Fabien requested review of this revision.Jul 2 2025, 15:15
teamcity edited the summary of this revision. (Show Details)Jul 2 2025, 15:15
Harbormaster completed remote builds in B33735: Diff 54653.Jul 2 2025, 15:26
Fabien added a child revision: D18313: test: Misc refactor to get rid of &foo[0] raw pointers.Jul 2 2025, 15:31
PiRK requested changes to this revision.Jul 2 2025, 19:48
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/test/validation_block_tests.cpp
83–85 ↗(On Diff #54653)

pubkey is now unused and can be removed

This revision now requires changes to proceed.Jul 2 2025, 19:48
Fabien added inline comments.Jul 2 2025, 21:30
src/test/validation_block_tests.cpp
83–85 ↗(On Diff #54653)

oups, I somehow did undo this removal...

Fabien updated this revision to Diff 54659.Jul 2 2025, 21:31

Remove dead code

Harbormaster completed remote builds in B33741: Diff 54659.Jul 2 2025, 21:45
PiRK accepted this revision.Jul 3 2025, 06:39
This revision is now accepted and ready to land.Jul 3 2025, 06:39
Closed by commit rABC2df009ca6b64: test: Move P2SH_OP_TRUE to shared test library (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJul 3 2025, 07:15
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC2df009ca6b64: test: Move P2SH_OP_TRUE to shared test library.

Revision Contents
Changeset List

PathSize
src/
test/
util/
15 lines
13 lines

Diff 54659

View Options

src/test/util/script.h

Loading...
View Options

src/test/validation_block_tests.cpp

Loading...