Paths

Table of Contentst

Differential D18313

test: Misc refactor to get rid of &foo[0] raw pointers
ClosedPublic
Actions

Authored by Fabien on Jul 2 2025, 15:31.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCfd29b02579d5: test: Misc refactor to get rid of &foo[0] raw pointers

Summary

Simplify test code

Backport of core#21840.

Depends on D18312.

Test Plan

ninja check
ninja bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR21840

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33736
Build 66950: Build Diff	lint-circular-dependencies · build-diff · build-without-wallet · build-bench · build-clang-tidy · build-clang · build-debug
Build 66949: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 2 2025, 15:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2025, 15:31

Fabien requested review of this revision.Jul 2 2025, 15:31

teamcity edited the summary of this revision. (Show Details)Jul 2 2025, 15:32

Fabien added a child revision: D18314: bench: BlockAssembler on a mempool with packages.Jul 2 2025, 15:38

Harbormaster completed remote builds in B33736: Diff 54654.Jul 2 2025, 15:45

PiRK accepted this revision.Jul 2 2025, 19:52

This revision is now accepted and ready to land.Jul 2 2025, 19:52

Closed by commit rABCfd29b02579d5: test: Misc refactor to get rid of &foo[0] raw pointers (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJul 3 2025, 07:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfd29b02579d5: test: Misc refactor to get rid of &foo[0] raw pointers.

Revision Contents
Changeset List

Path

Size

src/

bench/

block_assemble.cpp

19 lines

qt/

test/

rpcnestedtests.cpp

6 lines

test/

script_standard_tests.cpp

25 lines

Diff 54654

View Options

src/bench/block_assemble.cpp

View Options

src/qt/test/rpcnestedtests.cpp

View Options

src/test/script_standard_tests.cpp

test: Misc refactor to get rid of &foo[0] raw pointersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 54654

src/bench/block_assemble.cpp

src/qt/test/rpcnestedtests.cpp

src/test/script_standard_tests.cpp

test: Misc refactor to get rid of &foo[0] raw pointers
ClosedPublic
Actions

Revision Contents
Changeset List