Page MenuHomePhabricator
Differential D18338

[electrum] hw plugins: include a copy of pinmatrix.py from python-trezor, remove qt4 code
ClosedPublic
Actions

Authored by PiRK on Jul 8 2025, 13:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfae78f27107b: [electrum] hw plugins: include a copy of pinmatrix.py from python-trezor…
Summary

https://github.com/trezor/trezor-firmware/blob/3f1d2059ca140788dab8726778f05cedbea20bc4/python/src/trezorlib/qt/pinmatrix.py

I will use this in the trezor (and clones) plugins in a modified form to work with qt6.
Otherwise we would have to ask the trezor devs, who would actually respond,
but also the keepkey and safet lib authors, who would not... to support qt6.

https://github.com/spesmilo/electrum/commit/5d988af18d68e7425beba1962f2df328bb8a8661
https://github.com/spesmilo/electrum/commit/ecf0a5854de72186cab3d07b59993227f56a9212 (without the Qt6 specific API for now)

Test Plan
QT_API=pyqt6 ./electrum-abc
QT_API=pyqt5 ./electrum-abc

Open a pin protected Trezor One wallet

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 8 2025, 13:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2025, 13:23
PiRK requested review of this revision.Jul 8 2025, 13:23
Harbormaster completed remote builds in B33796: Diff 54741.Jul 8 2025, 13:29
PiRK added a child revision: D18339: [electrum] scripted-diff: use some Qt6 enums.Jul 8 2025, 13:45
PiRK edited the summary of this revision. (Show Details)Jul 8 2025, 13:49
PiRK updated this revision to Diff 54744.Jul 8 2025, 14:02

mention the SatoshiLabs copyright and LGPL3 license in COPYING

Fabien accepted this revision.Jul 8 2025, 14:07
Fabien added a subscriber: Fabien.

Please double check if the license is compatible and if there is anything more that has to be done in this regard

This revision is now accepted and ready to land.Jul 8 2025, 14:07
Harbormaster completed remote builds in B33799: Diff 54744.Jul 8 2025, 14:08
Closed by commit rABCfae78f27107b: [electrum] hw plugins: include a copy of pinmatrix.py from python-trezor… (authored by SomberNight <somber.night@protonmail.com>, committed by PiRK). · Explain WhyJul 9 2025, 07:52
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCfae78f27107b: [electrum] hw plugins: include a copy of pinmatrix.py from python-trezor….

Revision Contents
Changeset List

PathSize
electrum/
15 lines
electrumabc_plugins/
hw_wallet/
116 lines
keepkey/
3 lines
trezor/
3 lines

Diff 54757

View Options

electrum/COPYING

Loading...
View Options

electrum/electrumabc_plugins/hw_wallet/trezor_qt_pinmatrix.py

Loading...
View Options

electrum/electrumabc_plugins/keepkey/qt.py

Loading...
View Options

electrum/electrumabc_plugins/trezor/qt.py

Loading...