Page MenuHomePhabricator
Differential D18365

util: Use steady clock instead of system clock to measure durations
ClosedPublic
Actions

Authored by PiRK on Jul 15 2025, 11:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5c08c9f9716a: util: Use steady clock instead of system clock to measure durations
Summary

GetTimeMillis has multiple issues:

  • It doesn't denote the underlying clock type
  • It isn't type-safe
  • It is used incorrectly in places that should use a steady clock

Fix all issues here.

refactor, qt: Use std::chrono for MODEL_UPDATE_DELAY constant

https://github.com/bitcoin-core/gui/pull/517/commits/33d520ac538fcd6285fd958578f1bd26295592e4

net: Use steady clock in InterruptibleRecv

test: Use steady clock in index tests

See D14087 for why 30s in blockfilter_index_tests

wallet: Use steady clock to measure scanning duration

wallet: Use steady clock to calculate number of derive iterations

with MillisecondsDouble from core#26118

This is a backport of core#27405 and a partial backport of core-gui#517

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
15 lines
qt/
13 lines
7 lines
test/
6 lines
fuzz/
8 lines
6 lines
util/
2 lines
wallet/
3 lines
10 lines
26 lines

Diff 54877

View Options

src/netbase.cpp

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/qt/guiconstants.h

Loading...
View Options

src/test/blockfilter_index_tests.cpp

Loading...
View Options

src/test/fuzz/socks5.cpp

Loading...
View Options

src/test/txindex_tests.cpp

Loading...
View Options

src/util/time.h

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...