Paths

Table of Contentst

Differential D18365

util: Use steady clock instead of system clock to measure durations
ClosedPublic
Actions

Authored by PiRK on Jul 15 2025, 11:44.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5c08c9f9716a: util: Use steady clock instead of system clock to measure durations

Summary

GetTimeMillis has multiple issues:

It doesn't denote the underlying clock type
It isn't type-safe
It is used incorrectly in places that should use a steady clock

Fix all issues here.

refactor, qt: Use std::chrono for MODEL_UPDATE_DELAY constant

https://github.com/bitcoin-core/gui/pull/517/commits/33d520ac538fcd6285fd958578f1bd26295592e4

net: Use steady clock in InterruptibleRecv

test: Use steady clock in index tests

See D14087 for why 30s in blockfilter_index_tests

wallet: Use steady clock to measure scanning duration

wallet: Use steady clock to calculate number of derive iterations

with MillisecondsDouble from core#26118

This is a backport of core#27405 and a partial backport of core-gui#517

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 15 2025, 11:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2025, 11:44

PiRK requested review of this revision.Jul 15 2025, 11:44

teamcity edited the summary of this revision. (Show Details)Jul 15 2025, 11:44

Harbormaster completed remote builds in B33878: Diff 54850.Jul 15 2025, 11:58

Fabien accepted this revision.Jul 15 2025, 14:11

This revision is now accepted and ready to land.Jul 15 2025, 14:11

Closed by commit rABC5c08c9f9716a: util: Use steady clock instead of system clock to measure durations (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyJul 16 2025, 13:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5c08c9f9716a: util: Use steady clock instead of system clock to measure durations.

Revision Contents
Changeset List

Path

Size

src/

netbase.cpp

15 lines

qt/

clientmodel.cpp

13 lines

guiconstants.h

7 lines

test/

blockfilter_index_tests.cpp

6 lines

fuzz/

socks5.cpp

8 lines

txindex_tests.cpp

6 lines

util/

time.h

2 lines

wallet/

rpcwallet.cpp

3 lines

wallet.h

10 lines

wallet.cpp

26 lines

Diff 54877

View Options

src/netbase.cpp

View Options

src/qt/clientmodel.cpp

View Options

src/qt/guiconstants.h

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/fuzz/socks5.cpp

View Options

src/test/txindex_tests.cpp

View Options

src/util/time.h

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/wallet.h

View Options

util: Use steady clock instead of system clock to measure durationsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 54877

src/netbase.cpp

src/qt/clientmodel.cpp

src/qt/guiconstants.h

src/test/blockfilter_index_tests.cpp

src/test/fuzz/socks5.cpp

src/test/txindex_tests.cpp

src/util/time.h

src/wallet/rpcwallet.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

util: Use steady clock instead of system clock to measure durations
ClosedPublic
Actions

Revision Contents
Changeset List