Differential D18391

[ecash-wallet] Patch README to use correct import syntax and fromMnemonic constructor
ClosedPublic
Actions

Authored by bytesofman on Jul 21 2025, 10:19.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCf4ab4bff5721: [ecash-wallet] Patch README to use correct import syntax and fromMnemonic…

Summary

We no longer export Wallet default, so we need to import in brackets. Use the new fromMnemonic constructor in the README which will probably be the more common instantiation.

Test Plan

proofread

Diff Detail

Repository

rABC Bitcoin ABC

Branch

wallet-readme-patch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33922
Build 67314: Build Diff	ecash-wallet-integration-tests · ecash-wallet-tests · cashtab-faucet-tests
Build 67313: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 21 2025, 10:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2025, 10:19

version bump

fix typo, update change log link

Harbormaster completed remote builds in B33921: Diff 54922.Jul 21 2025, 10:29

Harbormaster completed remote builds in B33922: Diff 54923.Jul 21 2025, 10:33

Harbormaster completed remote builds in B33923: Diff 54924.Jul 21 2025, 10:36

bytesofman published this revision for review.Jul 21 2025, 10:44

Fabien accepted this revision.Jul 21 2025, 11:27

This revision is now accepted and ready to land.Jul 21 2025, 11:27

Closed by commit rABCf4ab4bff5721: [ecash-wallet] Patch README to use correct import syntax and fromMnemonic… (authored by bytesofman). · Explain WhyJul 21 2025, 11:31

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCf4ab4bff5721: [ecash-wallet] Patch README to use correct import syntax and fromMnemonic….

Revision Contents
Changeset List

Path

Size

modules/

ecash-wallet/

10 lines

package-lock.json

4 lines

2 lines

Diff 54923

modules/ecash-wallet/README.md

Loading...

modules/ecash-wallet/package-lock.json

Loading...

modules/ecash-wallet/package.json

Loading...