Differential D18392

[build] Use case insensitive checks for the allowed Windows libraries
ClosedPublic
Actions

Authored by Fabien on Jul 21 2025, 10:21.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC08e3b4199230: [build] Use case insensitive checks for the allowed Windows libraries

Summary

The files names in Windows are case insensitive so it makes sense to use a case insensitive check. This will fix the discrepeancy between KERNEL32.dll and kernel32.dll that we are currently facing depending the tools versions.

Test Plan

Run the windows GUIX build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

symbol_check_win_case_insensitive

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33924
Build 67318: Build Diff
Build 67317: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 21 2025, 10:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2025, 10:21

Harbormaster completed remote builds in B33924: Diff 54925.Jul 21 2025, 10:21

@bot guix-win

teamcity awarded a token.Jul 21 2025, 10:22

Fabien published this revision for review.Jul 21 2025, 11:23

PiRK accepted this revision.Jul 21 2025, 12:14

This revision is now accepted and ready to land.Jul 21 2025, 12:14

Closed by commit rABC08e3b4199230: [build] Use case insensitive checks for the allowed Windows libraries (authored by Fabien). · Explain WhyJul 21 2025, 14:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC08e3b4199230: [build] Use case insensitive checks for the allowed Windows libraries.

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

symbol-check.py

3 lines

Diff 54925

View Options

contrib/devtools/symbol-check.py

[build] Use case insensitive checks for the allowed Windows librariesClosedPublicActions