Page MenuHomePhabricator

[charts.e.cash, metachronik] Modify dockerfiles to build but not run commands
ClosedPublic

Authored by bytesofman on Jul 22 2025, 20:22.

Details

Summary

CI deployment for these apps will be similar to npm publishing. We build a docker container with the software we need, then we run a command. We do not need to continuously run the container for the production app; the container must run a command that will publish the production app (on railway for metachronik, on vercel for charts.e.cash)

However we need to pass arguments to the docker-run script we use in CI. So, take the commands out of the dockerfiles, and we will put them in teamcity in the deploy step.

Test Plan

proofread, comment on approach

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

at this point I don't see why we still use docker at all ?

This revision is now accepted and ready to land.Jul 22 2025, 22:01

at this point I don't see why we still use docker at all ?

Answering to self: so we don't have to install/maintain nodejs and npm on the CI agents