Page MenuHomePhabricator
Differential D18404

[metachronik, charts.e.cash] Add CMD to end of dockerfile to match pattern of npm deployment dockerfiles, which work
ClosedPublic
Actions

Authored by bytesofman on Jul 22 2025, 22:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7958b1e0a24a: [metachronik, charts.e.cash] Add CMD to end of dockerfile to match pattern of…
Summary

Use the same node image that works with npm and bash in the npm deployments

Test Plan

proofread, will land and do more testing in CI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
more-dockerfile-tweaks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33955
Build 67380: Build Diff
Build 67379: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 22 2025, 22:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2025, 22:19
Harbormaster completed remote builds in B33955: Diff 54970.Jul 22 2025, 22:19
bytesofman published this revision for review.Jul 22 2025, 22:20
bytesofman updated this revision to Diff 54971.Jul 22 2025, 22:20

newline

Harbormaster completed remote builds in B33956: Diff 54971.Jul 22 2025, 22:20
bytesofman updated this revision to Diff 54973.Jul 22 2025, 22:29

use image that has bash

Harbormaster completed remote builds in B33957: Diff 54973.Jul 22 2025, 22:30
bytesofman edited the summary of this revision. (Show Details)Jul 22 2025, 22:30
bytesofman updated this revision to Diff 54974.Jul 22 2025, 22:31

remove newlines

Harbormaster completed remote builds in B33958: Diff 54974.Jul 22 2025, 22:31
bytesofman updated this revision to Diff 54975.Jul 22 2025, 22:32

revert mysterious capital B

Harbormaster completed remote builds in B33959: Diff 54975.Jul 22 2025, 22:32
Fabien accepted this revision.Jul 22 2025, 22:32
This revision is now accepted and ready to land.Jul 22 2025, 22:32
Closed by commit rABC7958b1e0a24a: [metachronik, charts.e.cash] Add CMD to end of dockerfile to match pattern of… (authored by bytesofman). · Explain WhyJul 22 2025, 22:33
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC7958b1e0a24a: [metachronik, charts.e.cash] Add CMD to end of dockerfile to match pattern of….

Revision Contents
Changeset List

Diff 54970

View Options

charts.e.cash.Dockerfile

Loading...
View Options

metachronik.Dockerfile

Loading...