Page MenuHomePhabricator

[avalanche] Enable mining finalized transactions
ClosedPublic

Authored by Fabien on Jul 23 2025, 13:09.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCff646f2281f2: [avalanche] Enable mining finalized transactions
Summary

This require to only include the transactions that are still in the mempool.
Because the node keeps the radix tree untouched until the block is finalized, it would be possible for the node to generate a block template with confirmed transactions otherwise.

The feature is gated behind a dedicated flag for now. In the end this will be tied to preconsensus but this requires some tests to be updated first.

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_mining_preconsensus
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33961
Build 67392: Build Diffbuild-debug · build-without-wallet · build-diff · build-clang · build-clang-tidy · lint-circular-dependencies
Build 67391: arc lint + arc unit

Event Timeline

Fabien published this revision for review.Jul 23 2025, 14:00
PiRK added inline comments.
test/functional/abc_mining_avalanche_preconsensus.py
139–140
147

looks good, except for the comment nits

This revision is now accepted and ready to land.Jul 24 2025, 07:58